ci: add PR validation checks and release automation - #2
Merged
Conversation
Mirrors the CI setup from services-postgresql-rds: branch naming validation, conventional commit enforcement, shellcheck, a Trivy IaC scan on OpenTofu/Terraform files, and release-please based release automation, all via nullplatform/actions-nullplatform reusable workflows.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
storage_encrypted = true alone falls back to the AWS-managed RDS key, which fails AVD-AWS-0079 (trivy IaC scan requires an explicit kms_key_id on aws_rds_cluster). Add a dedicated KMS key instead of suppressing the check.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
services-postgresql-rdsalready has, vianullplatform/actions-nullplatformreusable workflows:branch-validation.yml— enforces branch naming convention on PRsconventional-commit.yml— enforces conventional commit messages on PRsshellcheck.yml— lints shell scripts on PRstrivy.yml— Trivy IaC scan over OpenTofu/Terraform files on PRsrelease.yml— release-please based release automation on push tomainci.yml(the existing nullplatform asset build/push workflow) is untouched.Notes
services-postgresql-rds, so all reusable workflows apply with their defaults — no repo-specific config needed.release.ymluses release-please's defaultterraform-modulerelease type, same as RDS.Test plan
mainand creates a release-please PR